netdev - Re: [PATCH] tg3: Separate TSO setup logic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Jun 2008 20:07:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org, mcarlson@...adcom.com
Subject: Re: [PATCH] tg3: Separate TSO setup logic.

From: "Michael Chan" <mchan@...adcom.com>
Date: Thu, 19 Jun 2008 20:04:48 -0700

> David, this goes on top of the 3rd patch to manage TX backlog.
> 
> tg3: Separate TSO setup logic.
> 
> Different TG3 chips require slightly different ways of setting up the
> TX descriptor and different initial values for some IP/TCP header
> fields.  It is cleaner to have dedicated TSO setup methods for the
> different chips and to call the proper one using a function pointer.
> The missing logic for TG3_FLG2_HW_TSO_2 has also been added.
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Thanks for doing this work michael.

If we put this at the end, it means we have a point in the series
where things are broken, and this makes "git bisect" unusable which
we try to avoid.

Therefore I'll try to integrate this work into my first patch.

Thanks again.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html