netdev - Re: [PATCH] IRDA: Fix genlmsg_put() return value check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2008 22:13:42 +0200
From:	<samuel@...tiz.org>
To:	Patrick McHardy <kaber@...sh.net>, Julius Volz <juliusv@...gle.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] IRDA: Fix genlmsg_put() return value check.


On Mon, 23 Jun 2008 21:43:31 +0200, Patrick McHardy <kaber@...sh.net>
wrote:
> Julius Volz wrote:
>> Fix an incorrect return value check of genlmsg_put() in
> irda_nl_get_mode().
>> genlmsg_put() does not use ERR_PTR() to encode return values, it just
>> returns NULL on error.
>>
>> Signed-off-by: Julius Volz <juliusv@...gle.com>
>> ---
>>  net/irda/irnetlink.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/net/irda/irnetlink.c b/net/irda/irnetlink.c
>> index 9e1fb82..ea11cb4 100644
>> --- a/net/irda/irnetlink.c
>> +++ b/net/irda/irnetlink.c
>> @@ -101,8 +101,8 @@ static int irda_nl_get_mode(struct sk_buff *skb,
> struct genl_info *info)
>>
>>  	hdr = genlmsg_put(msg, info->snd_pid, info->snd_seq,
>>  			  &irda_nl_family, 0,  IRDA_NL_CMD_GET_MODE);
>> -	if (IS_ERR(hdr)) {
>> -		ret = PTR_ERR(hdr);
>> +	if (hdr == NULL) {
>> +		ret = -ENOMEM;
>>  		goto err_out;
>>  	}
> 
> Good catch, but the correct return value for insufficient
> space in the skb is -ENOSPC.
Thanks Julius, Patrick. I'll take this one and send it with
my next IrDA patch set.

Cheers,
Samuel.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html