netdev - Re: [RESEND] [PATCH] tcp: fix for splice receive when used with software LRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2008 22:48:40 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Octavian Purdila <opurdila@...acom.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RESEND] [PATCH] tcp: fix for splice receive when used with
	software LRO

On Mon, Jun 23, 2008 at 12:50:30PM +0300, Octavian Purdila wrote:
> On Monday 23 June 2008, Jarek Poplawski wrote:
...
> > But, I think it's better to separate the change of functionality (a
> > recursive processing of frag_list) to another patch (if there is a
> > practical reason for this).
> >
> 
> Yes, it makes sense, I'll remove the recursion from this patch. 
> 
> About the recursion: don't know if it makes a difference from a functional 
> perspective (I don't think that we can have frag_lists in frag_lists), but 
> I've noticed that skb_copy_bits does recurse. Any idea why?

I meant it's potentially the change of functionality in this place.
Probably this recursion is intended for 1 level only, and is natural
in this place. But, since this place didn't use this, it should be
safer to separate this change to another patch (of course, consistency
with skb_copy_bits could be a good argument).

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html