netdev - Re: [2.6 patch] remove CONFIG_NET_SCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2008 14:52:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	bunk@...nel.org, kaber@...sh.net, netdev@...r.kernel.org,
	rpjday@...shcourse.ca
Subject: Re: [2.6 patch] remove CONFIG_NET_SCH_RR

From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Date: Mon, 23 Jun 2008 11:31:30 -0700

> >Commit d62733c8e437fdb58325617c4b3331769ba82d70
> >([SCHED]: Qdisc changes and sch_rr added for multiqueue)
> >added a NET_SCH_RR option that was unused since the code
> >went unconditionally into sch_prio.
> 
> I don't agree we should remove this option, purely for the fact that
> there isn't any way a user would know the qdisc existed without reading
> the code.

That's not how config options work.

We add features and facilities all the time that lack CONFIG
option entries.

And frankly, I plan on removing the RR scheduler in the TX
multiqueue bits I'm doing.

But even if I didn't plan this, we should remove these unused
CONFIG variables, because that is our tree wide policy.  We
don't use them as dinky knobs for documentation.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html