netdev - [PATCH] ibm_newemac: Fixes entry of short packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2008 14:55:05 +0200
From:	Stefan Roese <sr@...x.de>
To:	linuxppc-dev@...abs.org, netdev@...r.kernel.org
Cc:	benh@...nel.crashing.org, Sathya Narayanan <sathyan@...mf1.com>
Subject: [PATCH] ibm_newemac: Fixes entry of short packets

From: Sathya Narayanan <sathyan@...mf1.com>

Short packets has to be discarded by the driver. So this patch addresses the
issue of discarding the short packets of size lesser then ethernet header
size.

Signed-off-by: Sathya Narayanan <sathyan@...mf1.com>
Signed-off-by: Stefan Roese <sr@...x.de>
---
 drivers/net/ibm_newemac/core.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 6dfc2c9..aa407b2 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -1652,6 +1652,13 @@ static int emac_poll_rx(void *param, int budget)
 
 		skb_put(skb, len);
 	push_packet:
+		if (skb->len < ETH_HLEN) {
+			dev_kfree_skb(skb);
+			printk(KERN_WARNING "%s: short packets dropped\n",
+			       dev->ndev->name);
+			++dev->estats.rx_dropped_stack;
+			goto next;
+		}
 		skb->dev = dev->ndev;
 		skb->protocol = eth_type_trans(skb, dev->ndev);
 		emac_rx_csum(dev, skb, ctrl);
-- 
1.5.6

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html