netdev - Re: [PATCH] RFKILL: fix input layer initialisation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2008 11:24:53 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Dmitry Baryshkov <dbaryshkov@...il.com>
Cc:	netdev@...r.kernel.org, IvDoorn@...il.com, hmh@....eng.br
Subject: Re: [PATCH] RFKILL: fix input layer initialisation

On Mon, Jun 23, 2008 at 06:40:24PM +0400, Dmitry Baryshkov wrote:
> On Mon, Jun 23, 2008 at 09:22:39AM -0400, Dmitry Torokhov wrote:
> > Hi Dmitry,
> > 
> > On Thu, Jun 19, 2008 at 03:28:41PM +0400, Dmitry Baryshkov wrote:
> > > Initialise correctly last fields, so tasks can be actually executed
> > > 
> > > Also move rfkill-input initialisation to subsys level so that it's
> > > available before generic drivers probing occurs.
> > > 
> > 
> > Rfkill-input is an implementation of default policy of handling
> > wifi-related key presses, it is not mandatory and should not be
> > required for a driver to operate, it may even not be present in the
> > kernel and therefore module_init is the appropriate time for its
> > initialization. We don't expect user to start pushing WIFI buttons
> > while system just starting to boot up, do we?
> 
> I do toggle the KEY_BLUETOOTH from the kernel driver early.
> The preliminary patch can be found at
> http://permalink.gmane.org/gmane.linux.ports.arm.kernel/43136
> 
> The idea was to drive the bluetooth chip attached to the UART from the
> uart pm hook.
> 

Is there an actual button there? If not you should not create input
device. You probably need to talk to Henrique (CCed) about how
properly integrate rfkill support.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html