netdev - Re: [patch v2 02/11] DM9000: Fixup blackfin after removing 2 resource usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2008 10:00:26 +0800
From:	"Bryan Wu" <cooloney@...nel.org>
To:	"Ben Dooks" <ben-linux@...ff.org>
Cc:	"Ben Hutchings" <bhutchings@...arflare.com>,
	netdev@...r.kernel.org, jeff@...zik.org,
	"Laurent Pinchart" <laurentp@...-semaphore.com>
Subject: Re: [patch v2 02/11] DM9000: Fixup blackfin after removing 2 resource usage

On Mon, Jun 23, 2008 at 6:20 PM, Ben Dooks <ben-linux@...ff.org> wrote:
> On Mon, Jun 23, 2008 at 05:56:08PM +0800, Bryan Wu wrote:
>> On Mon, Jun 23, 2008 at 5:24 PM, Ben Dooks <ben-linux@...ff.org> wrote:
>> > On Sun, Jun 22, 2008 at 09:35:32PM +0100, Ben Hutchings wrote:
>> >> Ben Dooks wrote:
>> >> > From: Laurent Pinchart <laurentp@...-semaphore.com>
>> >> >
>> >> > The dm9000 driver accepts either 2 or 3 resources to describe the platform
>> >> > devices. The 2 resources case abuses the ioresource mechanism by passing
>> >> > ioremap()ed memory through the platform device resources. This patch removes
>> >> > converts boards that were using it to the 3 resources scheme.
>> >> [...]
>> >>
>> >> This needs to be applied before the previous patch, otherwise there's
>> >> a point where these boards are broken.
>> >
>> > There may be a small overlap, but I'd much rather fix the abuse than
>> > actually leave it in there much longer. The fixup patch has been cc'd
>> > to the blackfin maintainer, so any breakage will be minimal (and will
>> > also be clearly marked, it isn't as if the driver will just fail to
>> > work; there is a clear error being printed and it will gracefully
>> > exit).
>> >
>> > --
>>
>> I agree with Ben Hunchings here.
>>
>> Because this patch depends on previous patches in this series, could
>> you please merge this patch set as a whole DM9000 series?
>> If I merge this patch from Blackfin subsystem, there will be some
>> breakage before other DM9000 patches are merged.
>> So please merge this Blackfin fixup patch with other DM9000 patches together.
>>
>> And This patch is OK for Blackfin change.
>
> Hmm, if the patch depends on the previous one, then the three resource
> case for blackfin is broken, and will remain broken after this. The changes
> in arch/blackfin should be applyable before the removal of the two-resource
> case from the dm9000 driver?
>

Exactly, I do think so. I met similar conflict in serial tty driver updates.

> If you are happy with these changes to be merged via the netdev trees, then
> I'm sure that applying this entire set as-is would be fine with the network
> device maintainers.
>

I'd love to see that. Thanks.

-Bryan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html