netdev - Re: [PATCH 08/08] ipg: run-time configurable jumbo frame support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2008 23:57:05 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
Cc:	sorbica@...lus.com.tw, jesse@...lus.com.tw, Bircoph@...t.ru,
	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCH 08/08] ipg: run-time configurable jumbo frame support

Pekka J Enberg <penberg@...helsinki.fi> :
[...]
> @@ -2124,16 +2129,33 @@
>  
>  	IPG_DEBUG_MSG("_nic_change_mtu\n");
>  
> -	/* Check that the new MTU value is between 68 (14 byte header, 46
> -	 * byte payload, 4 byte FCS) and IPG_MAX_RXFRAME_SIZE, which
> -	 * corresponds to the MAXFRAMESIZE register in the IPG.
> +	/*
> +	 * Check that the new MTU value is between 68 (14 byte header, 46 byte
> +	 * payload, 4 byte FCS) and 10 KB, which is the largest supported MTU.
>  	 */
> -	if ((new_mtu < 68) || (new_mtu > sp->max_rxframe_size))
> +	if (new_mtu < 68 || new_mtu > 10240)
>  		return -EINVAL;
>  
> +	err = ipg_nic_stop(dev);
> +	if (err)
> +		return err;

I buy it but it would be nice if the error path was more tolerant: though
not immedialtely fatal, a failure during a change of mtu will be hard to
recover from.

Could you be convinced to plan some descriptor ring trick instead of
a genuine stop / start sequence.

Something along the lines of
http://userweb.kernel.org/~romieu/via-velocity/2.6.26-rc6/20080619/
for instance (or anything more elegant you can come with).

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html