netdev - [PATCH] net: em_cmp.c use unaligned access helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Jun 2008 16:20:37 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: [PATCH] net: em_cmp.c use unaligned access helpers

Explicitly check the endianness and use the appropriate unaligned
access helpers rather than conditionally byteswapping after the
unaligned access.

Fixes a bug on big-endian machines where be16/be32_to_cpu are no-ops
and would miss byteswapping in the le case.

Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
---
Dave, here's a complete patch if you want to apply.

 net/sched/em_cmp.c |   17 +++++++----------
 1 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/net/sched/em_cmp.c b/net/sched/em_cmp.c
index cc49c93..afd2d7a 100644
--- a/net/sched/em_cmp.c
+++ b/net/sched/em_cmp.c
@@ -14,6 +14,7 @@
 #include <linux/kernel.h>
 #include <linux/skbuff.h>
 #include <linux/tc_ematch/tc_em_cmp.h>
+#include <asm/unaligned.h>
 #include <net/pkt_cls.h>
 
 static inline int cmp_needs_transformation(struct tcf_em_cmp *cmp)
@@ -37,23 +38,19 @@ static int em_cmp_match(struct sk_buff *skb, struct tcf_ematch *em,
 			break;
 
 		case TCF_EM_ALIGN_U16:
-			val = *ptr << 8;
-			val |= *(ptr+1);
-
 			if (cmp_needs_transformation(cmp))
-				val = be16_to_cpu(val);
+				val = get_unaligned_le16(ptr);
+			else
+				val = get_unaligned_be16(ptr);
 			break;
 
 		case TCF_EM_ALIGN_U32:
 			/* Worth checking boundries? The branching seems
 			 * to get worse. Visit again. */
-			val = *ptr << 24;
-			val |= *(ptr+1) << 16;
-			val |= *(ptr+2) << 8;
-			val |= *(ptr+3);
-
 			if (cmp_needs_transformation(cmp))
-				val = be32_to_cpu(val);
+				val = get_unaligned_le32(ptr);
+			else
+				val = get_unaligned_be32(ptr);
 			break;
 
 		default:
-- 
1.5.6.1.179.g18c1f



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html