lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jun 2008 10:34:33 +0100 From: David Woodhouse <dwmw2@...radead.org> To: "Chas Williams (CONTRACTOR)" <chas@....nrl.navy.mil> Cc: netdev@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware() On Thu, 2008-06-05 at 12:06 -0400, Chas Williams (CONTRACTOR) wrote: > yes, it is troubling. along the same lines, this patch removes the > pca200e/sba200e firmware from the kernel. the firmware will be in the > next release of the userspace atm tools. i could move the ambassador > firmware there as well if you would like. Sorry for dropping this; I'll let it go through the net tree now it's there. A couple of comments though... it looks like you forgot to add MODULE_FIRMWARE(). And shouldn't 'fw_data' in fore200e_load_and_start_firmware() be a (__le32 *) not a (u32 *)? -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists