netdev - Re: [PATCH 6/8] netfilter: fix string extension for case insensitive pattern matching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2008 21:09:12 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Joonwoo Park <joonwpark81@...il.com>
cc:	Patrick McHardy <kaber@...sh.net>, netdev <netdev@...r.kernel.org>,
	netfilter-devel <netfilter-devel@...r.kernel.org>,
	Thomas Graf <tgraf@...g.ch>,
	Pablo Neira Ayuso <pablo@...filter.org>
Subject: Re: [PATCH 6/8] netfilter: fix string extension for case insensitive
 pattern matching


On Monday 2008-06-30 20:44, Joonwoo Park wrote:
>> Why not just doing it this way?
>>
>>
>> enum {
>>        XT_STRING_INVERT = 1 << 0,
>>        XT_STRING_ICASE  = 1 << 1,
>> };
>>
>> struct xt_string_info {
>>        ...
>>        union {
>>                uint8_t invert;
>>                uint8_t flags;
>>        };
>>        ...
>> };
>>
>>
>
>Not bad for me,
>I think invert might be removed and flags can contain XT_STRING_INVERT as well.

Right, since we copy eader files anyway, we can just make it uint8_t flags
without the union.

>But I guess we should do version checking between user-space and
>kernel more strictly whatever.

That is what we have '.revision' in xt_match/xt_target for.
In this case however it should be fine with just flags.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html