netdev - Re: v2 [PATCH net-next 1/8] af_packet: Check return of dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Jul 2008 17:42:42 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	Patrick McHardy <kaber@...sh.net>
CC:	"David S. Miller" <davem@...emloft.net>,
	NETDEV <netdev@...r.kernel.org>
Subject: Re: v2 [PATCH net-next 1/8] af_packet: Check return of dev_set_promiscuity/allmulti

Patrick McHardy said the following on 2008-7-1 17:36:
> Wang Chen wrote:
>> dev_set_promiscuity/allmulti might overflow.
>> Commit: "netdevice: Fix promiscuity and allmulti overflow" in net-next
>> makes
>> dev_set_promiscuity/allmulti return error number if overflow happened.
>>
>> In af_packet, we check all positive increment for promiscuity and
>> allmulti
>> to get error return.
>>
>>  static void packet_dev_mclist(struct net_device *dev, struct
>> packet_mclist *i, int what)
>> @@ -1245,7 +1247,7 @@ static int packet_mc_add(struct sock *sk, struct
>> packet_mreq_max *mreq)
>>      i->count = 1;
>>      i->next = po->mclist;
>>      po->mclist = i;
>> -    packet_dev_mc(dev, i, +1);
>> +    err = packet_dev_mc(dev, i, 1);
> 
> Missing error handling. The packet_mclist is already initialized
> and on the list here, which will result in deletion without
> addition in packet_flush_mclist().
> 

will do.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html