netdev - Re: [PATCH] ehea: Access iph->tot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Jul 2008 16:45:37 +0200
From:	Thomas Klein <osstklei@...ibm.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	jeff@...zik.org, netdev@...r.kernel.org, themann@...ibm.com
Subject: Re: [PATCH] ehea: Access iph->tot_len with correct endianness

Roland Dreier wrote:
> iph->tot_len is stored in network byte order, so access it using
> ntohs().  This doesn't have any real world impact on ehea, since ehea
> only exists for big-endian platfroms (at the moment at least) but fixing
> this gets rid of a sparse warning and avoids having a bad example in the
> tree.
> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>
> ---
>  drivers/net/ehea/ehea_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
> index 075fd54..451b7e6 100644
> --- a/drivers/net/ehea/ehea_main.c
> +++ b/drivers/net/ehea/ehea_main.c
> @@ -616,7 +616,7 @@ static int get_skb_hdr(struct sk_buff *skb, void **iphdr,
>  	*tcph = tcp_hdr(skb);
>  
>  	/* check if ip header and tcp header are complete */
> -	if (iph->tot_len < ip_len + tcp_hdrlen(skb))
> +	if (ntohs(iph->tot_len) < ip_len + tcp_hdrlen(skb))
>  		return -1;
>  
>  	*hdr_flags = LRO_IPV4 | LRO_TCP;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Correct. Thanks Roland!

Acked-by: Thomas Klein <tklein@...ibm.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html