netdev - Re: [PATCH 00/06]: VLAN TCI truncation fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 06 Jul 2008 21:51:26 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Patrick McHardy <kaber@...sh.net>,
	David Miller <davem@...emloft.net>
CC:	Linux Netdev List <netdev@...r.kernel.org>,
	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	john.ronciak@...el.com, ionut@...columbia.edu,
	baum@...utinetworks.net, andy@...yhouse.net
Subject: Re: [PATCH 00/06]: VLAN TCI truncation fixes

Patrick McHardy wrote:
> These patches fix all drivers supporting VLAN header stripping to
> pass the complete VLAN TCI to vlan_hwaccel_{rx,receive_skb} instead
> of just the VID. The upper three bits contain the priority and are
> used for ingress priority mappings.
> 
> The e1000 patch is runtime tested, the others only compile tested.
> 
> 
> drivers/net/e1000/e1000_main.c |   12 ++++--------
> drivers/net/e1000e/netdev.c    |    3 +--
> drivers/net/igb/igb_main.c     |    3 +--
> drivers/net/ixgb/ixgb_main.c   |    6 ++----
> drivers/net/starfire.c         |    2 +-
> drivers/net/tehuti.c           |    2 +-
> drivers/net/tehuti.h           |    1 +
> 7 files changed, 11 insertions(+), 18 deletions(-)
> 
> Patrick McHardy (6):
>      e1000: don't truncate VLAN TCI with VLAN stripping
>      e1000e: don't truncate VLAN TCI with VLAN stripping
>      igb: don't truncate VLAN TCI with VLAN stripping
>      ixgb: don't truncate VLAN TCI with VLAN stripping
>      starfire: don't truncate VLAN TCI with VLAN stripping
>      tehuti: don't truncate VLAN TCI with VLAN stripping

Acked-by: Jeff Garzik <jgarzik@...hat.com>

Though I would suggest combining all these patches into a single patch, 
since they constitute a single logical change, and each change is 
self-contained and small.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html