lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 07 Jul 2008 18:59:45 +0200 From: Patrick McHardy <kaber@...sh.net> To: Ben Hutchings <bhutchings@...arflare.com> CC: davem@...emloft.net, netdev@...r.kernel.org Subject: Re: vlan 03/07: Add ethtool support Ben Hutchings wrote: > Patrick McHardy wrote: >> vlan: Add ethtool support >> >> Add ethtool support for querying the device for offload settings. >> >> Signed-off-by: Patrick McHardy <kaber@...sh.net> > [...] >> +static u32 vlan_ethtool_get_rx_csum(struct net_device *dev) >> +{ >> + const struct vlan_dev_info *vlan = vlan_dev_info(dev); >> + struct net_device *real_dev = vlan->real_dev; >> + >> + if (real_dev->ethtool_ops == NULL || >> + real_dev->ethtool_ops->get_rx_csum == NULL) >> + return 0; >> + return real_dev->ethtool_ops->get_rx_csum(real_dev); > > But we don't know whether RX checksum offload applies to VLAN-tagged > packets (or, admittedly, any specific protocol). It would be nice if there > was a feature flag for this so it could be advertised in vlan_features. True, for now the assumption is that it works for VLANs. I don't think that assumption is unreasonable, but I can look into a separate flag for this. > >> +} >> + >> +static const struct ethtool_ops vlan_ethtool_ops = { >> + .get_link = ethtool_op_get_link, >> + .get_rx_csum = vlan_ethtool_get_rx_csum, > > Can't we also add: > > .get_tx_csum = ethtool_op_get_tx_csum, > .get_sg = ethtool_op_get_sg, > .get_tso = ethtool_op_get_tso, > .get_flags = ethtool_op_get_flags, Besides get_flags all of these are handled by default handlers. What is get_flags used for? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists