netdev - Re: [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 08 Jul 2008 22:15:55 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
CC:	Nicolas Pitre <nico@....org>,
	Dale Farnsworth <dale@...nsworth.org>,
	Ashish Karkare <akarkare@...vell.com>,
	Jesper Dangaard Brouer <jdb@...x.dk>, netdev@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan
 tag by hand

Lennert Buytenhek wrote:
> On Tue, Jul 08, 2008 at 08:50:09PM +0200, Patrick McHardy wrote:
> 
>> commit 9381fc4a49cb8b75d5ff38e4f5d14d7e135adc4c
>> Author: Patrick McHardy <kaber@...sh.net>
>> Date:   Tue Jul 8 19:56:17 2008 +0200
>>
>>     vlan: avoid header copying and linearisation where possible
> 
> That gives me:
> 
> - 2.6.26-rc9 + [1] + [2] + this patch: ~75 sec, 13.6 MiB/s
> 
> So it's almost back to the non-VLAN case.


Great, thanks. The patch applies cleanly with or without the VLAN
packet socket patches I sent today, so Dave can either just apply
it together with your mv643xx_eth patch or I'll include it when
sending the next VLAN update.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html