netdev - Re: [PATCH] Traffic control cgroups subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2008 08:56:04 -0400
From:	"Paul Menage" <menage@...gle.com>
To:	"Patrick McHardy" <kaber@...sh.net>
Cc:	"Ranjit Manomohan" <ranjitm@...gle.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	lizf@...fujitsu.com
Subject: Re: [PATCH] Traffic control cgroups subsystem

On Tue, Jul 22, 2008 at 8:48 AM, Patrick McHardy <kaber@...sh.net> wrote:
>
> Using skb->priority for classification would be fine, but it would
> probably interfere with the default initialization to sk->sk_priority.

Well internally we just overloaded sk->sk_priority to be the classid,
and let skb->priority be inherited from that.

>
>> Regarding skb->sk->sk_cgroup_classid, is it always the case that the
>> original sk is still available when we're making traffic control
>> decisions? I'd thought that there were cases (e.g. cloning skbs in the
>> TCP retransmit path) where the pointer to the original sk is lost.
>
> After cloning, TCP sets the owner of the skb to the socket, so
> that should work fine.
>

OK, so maybe we don't need a per-skb field after all.

Paul
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html