lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Jul 2008 18:21:13 +0300 From: Paulius Zaleckas <paulius.zaleckas@...tonika.lt> To: netdev@...r.kernel.org Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] Blackfin EMAC Driver: add proper __devinit/__devexit markings Bryan Wu wrote: > From: Mike Frysinger <vapier.adi@...il.com> > > Signed-off-by: Mike Frysinger <vapier.adi@...il.com> > Signed-off-by: Bryan Wu <cooloney@...nel.org> > --- > drivers/net/bfin_mac.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c > index 4144343..17951cb 100644 > --- a/drivers/net/bfin_mac.c > +++ b/drivers/net/bfin_mac.c > @@ -956,7 +956,7 @@ static int bfin_mac_close(struct net_device *dev) > return 0; > } > > -static int __init bfin_mac_probe(struct platform_device *pdev) > +static int __devinit bfin_mac_probe(struct platform_device *pdev) __init was OK here. __devinit is for hotplug devices > { > struct net_device *ndev; > struct bfin_mac_local *lp; > @@ -1082,7 +1082,7 @@ out_err_probe_mac: > return rc; > } > > -static int bfin_mac_remove(struct platform_device *pdev) > +static int __devexit bfin_mac_remove(struct platform_device *pdev) __devexit is for hotplug, use __exit > { > struct net_device *ndev = platform_get_drvdata(pdev); > struct bfin_mac_local *lp = netdev_priv(ndev); > @@ -1129,7 +1129,7 @@ static int bfin_mac_resume(struct platform_device *pdev) > > static struct platform_driver bfin_mac_driver = { > .probe = bfin_mac_probe, .probe shouldn't be declared here. And you should use platform_device_probe() instead of platform_device_add() > - .remove = bfin_mac_remove, > + .remove = __devexit_p(bfin_mac_remove), should be __exit_p() > .resume = bfin_mac_resume, > .suspend = bfin_mac_suspend, > .driver = { -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists