netdev - Re: [PATCH] blackfin_mac: unneeded assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2008 14:48:18 +0800
From:	"Bryan Wu" <cooloney@...nel.org>
To:	"Stephen Hemminger" <shemminger@...tta.com>
Cc:	"Jeff Garzik" <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] blackfin_mac: unneeded assignment

On Sat, Jul 26, 2008 at 2:46 AM, Stephen Hemminger
<shemminger@...tta.com> wrote:
> skb->dev is set by eth_type_trans already.
>

Right, I'd love to add it into my queue.
Applied.

Acked-by: Bryan Wu <cooloney@...nel.org>

> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>
>
> --- a/drivers/net/bfin_mac.c    2008-07-25 10:19:53.000000000 -0700
> +++ b/drivers/net/bfin_mac.c    2008-07-25 10:20:53.000000000 -0700
> @@ -691,7 +691,6 @@ static void bfin_mac_rx(struct net_devic
>                                         (unsigned long)skb->tail);
>
>        dev->last_rx = jiffies;
> -       skb->dev = dev;
>        skb->protocol = eth_type_trans(skb, dev);
>  #if defined(BFIN_MAC_CSUM_OFFLOAD)
>        skb->csum = current_rx_ptr->status.ip_payload_csum;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html