netdev - Re: [patch 2.6.26-git] enc28j60: don't specify (wrong) IRQ type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2008 18:24:57 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	David Brownell <david-b@...bell.net>
CC:	Network development list <netdev@...r.kernel.org>,
	Claudio Lanconelli <lanconelli.claudio@...ar.com>
Subject: Re: [patch 2.6.26-git] enc28j60: don't specify (wrong) IRQ type

David Brownell wrote:
> From: David Brownell <dbrownell@...rs.sourceforge.net>
> 
> Recent changes to the IRQ framework have made passing the wrong
> trigger type to request_irq() become a fatal error.  In the case
> of the enc28j60 driver, it stopped working in my test harness.
> 
> (Specifically:  the signal detects "pin change" events, both edges,
> not just falling edges.  Similarly, other boards might route it
> through an inverter.  Trigger type are board-specific.)
> 
> This fixes that problem by the usual fix of expecting board setup
> code to have set up the correct IRQ trigger type.  The best known
> example of that being x86 setup.
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html