netdev - Re: [RFC][PATCH 1/2] net: support for TX timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2008 16:36:55 +0300
From:	Octavian Purdila <opurdila@...acom.com>
To:	Patrick Ohly <patrick.ohly@...el.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [RFC][PATCH 1/2] net: support for TX timestamps

On Wednesday 30 July 2008, Patrick Ohly wrote:

> > I don't think that skb->sk is guaranteed to be around in hard_start_xmit.
> > But we should not need it, if we overload the skb->tstamp, right?
>
> skb->sk is needed in skb_tx_timestamp() to send the copied skb with the
> time stamp back to the application, isn't it? skb_tx_timestamp() won't
> crash, but it won't be able to do the desired action either. Overloading
> skb->tstamp doesn't help with that.
>

Yes you are right :)

> I don't know where the connection to the originating socket is lost, but
> in linux-2.6 as of one week ago (not 2.6.26, as I said above) the
> skb->sk pointer is indeed NULL for the PTP broadcast packets - I just
> checked again.

Thanks for letting me know, I will look into it.

tavi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html