lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Jul 2008 16:20:53 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Wei Yongjun <yjwei@...fujitsu.com> Cc: David Miller <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH] ipv6: Fix ip6_xmit to send fragments if ipfragok is true On Thu, Jul 31, 2008 at 01:55:57PM +0800, Wei Yongjun wrote: > SCTP used ip6_xmit() to send fragments after received ICMP packet too > big message. But while send packet used ip6_xmit, the skb->local_df is > not initialized. So when skb if enter ip6_fragment > <../cgi-bin/global.cgi?pattern=ip6_fragment&type=reference>(), the following > code will discard the skb. That sounds broken. ip6_xmit is for TCP-like protocols that perform PMTU-discovery. Therefore it should never fragment locally. So either SCTP needs to do the same, or it should switch to something other than ip6_xmit. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists