lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Aug 2008 06:34:23 +0000 From: Jarek Poplawski <jarkao2@...il.com> To: David Miller <davem@...emloft.net> Cc: kaber@...sh.net, jussi.kivilinna@...et.fi, netdev@...r.kernel.org Subject: Re: [PATCH 2/2 respin] net_sched: Add qdisc __NET_XMIT_BYPASS flag On Mon, Aug 04, 2008 at 11:14:49PM -0700, David Miller wrote: ... > After applying this I noticed that dst_input()'s usage of > plain NET_XMIT_BYPASS was bogus, and after killing that > there are no more references. > > Thus I added the following commit. > > commit cc6533e98a7f3cb7fce9d740da49195c7aa523a4 > Author: David S. Miller <davem@...emloft.net> > Date: Mon Aug 4 23:04:08 2008 -0700 > > net: Kill plain NET_XMIT_BYPASS. > > dst_input() was doing something completely absurd, looping > on skb->dst->input() if NET_XMIT_BYPASS was seen, but these > functions never return such an error. > > And as a result plain ole' NET_XMIT_BYPASS has no more > references and can be completely killed off. > > Signed-off-by: David S. Miller <davem@...emloft.net> > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index abbf5d5..488c56e 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -61,9 +61,6 @@ struct wireless_dev; > #define NET_XMIT_DROP 1 /* skb dropped */ > #define NET_XMIT_CN 2 /* congestion notification */ > #define NET_XMIT_POLICED 3 /* skb is shot by police */ > -#define NET_XMIT_BYPASS 4 /* packet does not leave via dequeue; > - (TC use only - dev_queue_xmit > - returns this as NET_XMIT_SUCCESS) */ > #define NET_XMIT_MASK 0xFFFF /* qdisc flags in net/sch_generic.h */ > > /* Backlog congestion levels */ > diff --git a/include/net/dst.h b/include/net/dst.h > index c5c318a..8a8b71e 100644 > --- a/include/net/dst.h > +++ b/include/net/dst.h > @@ -252,17 +252,7 @@ static inline int dst_output(struct sk_buff *skb) > /* Input packet from network to transport. */ > static inline int dst_input(struct sk_buff *skb) > { > - int err; > - > - for (;;) { > - err = skb->dst->input(skb); > - > - if (likely(err == 0)) > - return err; > - /* Oh, Jamal... Seems, I will not forgive you this mess. :-) */ > - if (unlikely(err != NET_XMIT_BYPASS)) > - return err; > - } > + return skb->dst->input(skb); > } NAK! You're not allowed to remove such a great comment! BTW, I hope you've checked this enough, becouse I've some doubts here: this NET_XMIT_BYPASS looks wrong here but maybe it was meant to be some NET_RX_ code, like NET_RX_CN_HIGH? Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists