lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 06 Aug 2008 12:25:48 +0200 From: Patrick McHardy <kaber@...sh.net> To: Denys Fedoryshchenko <denys@...p.net.lb> CC: Stephen Hemminger <shemminger@...ux-foundation.org>, netdev@...r.kernel.org Subject: Re: iproute2 proposal Denys Fedoryshchenko wrote: > On Wednesday 06 August 2008, Patrick McHardy wrote: > >> No patch attached .. > > Sorry :-) Now must be attached > +++ iproute2-patched/tc/m_mirred.c 2008-08-06 09:49:39.000000000 +0000 > @@ -27,6 +27,7 @@ > #include <linux/tc_act/tc_mirred.h> > > int mirred_d = 1; > +extern int link_cache; > > static void > explain(void) > @@ -146,7 +147,10 @@ > > if (d[0]) { > int idx; > - ll_init_map(&rth); > + if (!link_cache) { > + ll_init_map(&rth); > + link_cache = 1; > + } It would be nicer to avoid the initialization in ll_init_map() as you did in your first patch and add an explicit ll_invalidate_map() and call it when necessary (ip link add/del/change(?), ip tunnel add/del/change(?)). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists