netdev - Re: [PATCH] METH: fix MAC address setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Aug 2008 02:12:21 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
CC:	netdev@...r.kernel.org, linux-mips@...ux-mips.org,
	ralf@...ux-mips.org
Subject: Re: [PATCH] METH: fix MAC address setup

Thomas Bogendoerfer wrote:
> Setup of the mac filter lost the upper 16bit of the mac address. This
> bug got unconvered by a patch, which fixed the promiscous handling.
> 
> Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> ---
> 
>  drivers/net/meth.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/meth.c b/drivers/net/meth.c
> index 4cb364e..0a97c26 100644
> --- a/drivers/net/meth.c
> +++ b/drivers/net/meth.c
> @@ -100,7 +100,7 @@ static inline void load_eaddr(struct net_device *dev)
>  	DPRINTK("Loading MAC Address: %s\n", print_mac(mac, dev->dev_addr));
>  	macaddr = 0;
>  	for (i = 0; i < 6; i++)
> -		macaddr |= dev->dev_addr[i] << ((5 - i) * 8);
> +		macaddr |= (u64)dev->dev_addr[i] << ((5 - i) * 8);

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html