netdev - Re: [patch for 2.6.27? 2/2] drivers/net/netxen/netxen_nic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 07 Aug 2008 02:24:02 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org
Subject: Re: [patch for 2.6.27? 2/2] drivers/net/netxen/netxen_nic_hw.c: fix
 printk warnings

akpm@...ux-foundation.org wrote:
> From: Andrew Morton <akpm@...ux-foundation.org>
> 
> drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_pci_mem_read_direct':
> drivers/net/netxen/netxen_nic_hw.c:1414: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
> drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_pci_mem_write_direct':
> drivers/net/netxen/netxen_nic_hw.c:1487: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
> 
> You don't know what type was used for u64 hence they cannot be printed without
> casting.
> 
> Cc: Jeff Garzik <jeff@...zik.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/netxen/netxen_nic_hw.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff -puN drivers/net/netxen/netxen_nic_hw.c~drivers-net-netxen-netxen_nic_hwc-fix-printk-warnings drivers/net/netxen/netxen_nic_hw.c
> --- a/drivers/net/netxen/netxen_nic_hw.c~drivers-net-netxen-netxen_nic_hwc-fix-printk-warnings
> +++ a/drivers/net/netxen/netxen_nic_hw.c
> @@ -1411,7 +1411,8 @@ static int netxen_nic_pci_mem_read_direc
>  		(netxen_nic_pci_is_same_window(adapter, off+size-1) == 0)) {
>  		write_unlock_irqrestore(&adapter->adapter_lock, flags);
>  		printk(KERN_ERR "%s out of bound pci memory access. "
> -			"offset is 0x%llx\n", netxen_nic_driver_name, off);
> +			"offset is 0x%llx\n", netxen_nic_driver_name,
> +			(unsigned long long)off);
>  		return -1;
>  	}
>  
> @@ -1484,7 +1485,8 @@ netxen_nic_pci_mem_write_direct(struct n
>  		(netxen_nic_pci_is_same_window(adapter, off+size-1) == 0)) {
>  		write_unlock_irqrestore(&adapter->adapter_lock, flags);
>  		printk(KERN_ERR "%s out of bound pci memory access. "
> -			"offset is 0x%llx\n", netxen_nic_driver_name, off);
> +			"offset is 0x%llx\n", netxen_nic_driver_name,
> +			(unsigned long long)off);
>  		return -1;
>  	}
>  
> _

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html