lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Aug 2008 10:31:30 +0000 From: Jarek Poplawski <jarkao2@...il.com> To: David Miller <davem@...emloft.net> Cc: jussi.kivilinna@...et.fi, kaber@...sh.net, netdev@...r.kernel.org Subject: Re: qdisc_enqueue, NET_XMIT_SUCCESS and kfree_skb On Thu, Aug 07, 2008 at 03:10:58AM -0700, David Miller wrote: > From: Jarek Poplawski <jarkao2@...il.com> > Date: Thu, 7 Aug 2008 10:09:10 +0000 ... > > After some checking it looks mostly OK to me, but one thing: in > > sch_gred gred_drop() calls qdisc_drop(), so now it needs kfree_skb(). > > BTW, maybe it would be nicer to add __qdisc_drop() for these new > > things? > > qdisc_drop() sets the new __NET_XMIT_KFREE bit, but sch_gred wants to > return NET_XMIT_CN, so I OR'd in the __NET_XMIT_KFREE bit there. Hmm... I'm not sure we're thinking about the same function? Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists