lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Aug 2008 15:02:58 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jarkao2@...il.com Cc: denys@...p.net.lb, netdev@...r.kernel.org Subject: Re: panic 2.6.27-rc3-git2, qdisc_dequeue_head From: Jarek Poplawski <jarkao2@...il.com> Date: Sun, 17 Aug 2008 23:47:52 +0200 > @@ -638,9 +638,9 @@ static void notify_and_destroy(struct sk_buff *skb, struct nlmsghdr *n, u32 clid > qdisc_notify(skb, n, clid, old, new); > > if (old) { > - spin_lock_bh(&old->q.lock); > + sch_tree_lock(old); > qdisc_destroy(old); > - spin_unlock_bh(&old->q.lock); > + sch_tree_unlock(old); > } > } > Ok, this makes sense, for the classful qdisc case. If we really wanted to be super-careful, we could remember the root qdisc at the top of qdisc_graft() and pass that into notify_and_destroy(). -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists