netdev - Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2008 02:42:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	Linux-Driver@...gic.com, netdev@...r.kernel.org
Subject: Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

From: Jeff Garzik <jeff@...zik.org>
Date: Fri, 22 Aug 2008 05:22:17 -0400

> - The kmap use is interesting

It's so much easier to just always tack on the pages or whatever
and use __pskb_pull_tail(skb, SOME_MIN_HEADER_LENGTH)

I also notice that this driver does not do:

	skb_reserve(skb, NET_IP_ALIGN);

on RX packets to get the IP headers properly 4-byte aligned aligned
after the ethernet header.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html