netdev - Re: [PATCH take 2] pkt_sched: Fix qdisc list locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Aug 2008 03:28:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	jarkao2@...il.com, netdev@...r.kernel.org, denys@...p.net.lb
Subject: Re: [PATCH take 2] pkt_sched: Fix qdisc list locking

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 22 Aug 2008 20:15:26 +1000

> On Fri, Aug 22, 2008 at 09:27:30AM +0000, Jarek Poplawski wrote:
> > 
> > pkt_sched: Fix qdisc list locking
> > 
> > Since some qdiscs call qdisc_tree_decrease_qlen() (so qdisc_lookup())
> > without rtnl_lock(), adding and deleting from a qdisc list needs
> > additional locking. This patch adds global spinlock qdisc_list_lock
> > and wrapper functions for modifying the list. It is considered as a
> > temporary solution until hfsc_dequeue(), netem_dequeue() and
> > tbf_dequeue() (or qdisc_tree_decrease_qlen()) are redone.
> > 
> > With feedback from Herbert Xu and David S. Miller.
> > 
> > Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

I'll add you ACK, thanks Herbert.

> Good catch! I'm not sure whether this would actually break but
> it certainly makes me feel a lot better :)

Thankfully list_del() on an empty list works or we'd have tons of
reports :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html