netdev - Re: [PATCH 1/2] ne.c fix, res->name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Sep 2008 02:15:05 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	david@...es.net
Cc:	linux-kernel@...r.kernel.org, p_gortmaker@...oo.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] ne.c fix, res->name

On Sat, 30 Aug 2008 13:05:03 -0500, David Fries <david@...es.net> wrote:
> On Sun, Aug 31, 2008 at 12:03:57AM +0900, Atsushi Nemoto wrote:
> > On Fri, 29 Aug 2008 21:44:25 -0500, David Fries <david@...es.net> wrote:
> > > +	if (!strcmp(res->name, BAD_STR))
> > > +		dev->mem_end = BAD;
> > 
> > The res->name might be NULL.  You should check it first.
> > 
> > 	if (res->name && !strcmp(res->name, BAD_STR))
> > 		dev->mem_end = BAD;
> 
> The name gets a valid string by that point in time.
> 
> drivers/base/platform.c:257

Oh, you are right.  Sorry for noise.

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html