netdev - Re: [PATCH 2/3] ibm_newemac: Introduce mal_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 4 Sep 2008 23:37:24 -0400
From:	Josh Boyer <jwboyer@...ux.vnet.ibm.com>
To:	benh@...nel.crashing.org
Cc:	netdev@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH 2/3] ibm_newemac: Introduce mal_has_feature

On Fri, 05 Sep 2008 13:19:23 +1000
Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:

> On Thu, 2008-09-04 at 11:02 -0400, Josh Boyer wrote:
> > There are some PowerPC SoCs that do odd things with the MAL handling.  In
> > order to accommodate them, we need to introduce a feature mechanism that is
> > similar to the existing emac_has_feature function.
> > 
> > This adds a feature variable to the mal_instance structure, and adds a
> > mal_has_feature function with some feature definitions.  These are guarded
> > by Kconfig options that are selected by the affected platforms.
> > 
> > Signed-of-by: Josh Boyer <jwboyer@...ux.vnet.ibm.com>
> 
> You also add an actual feature (CLR_ICINSTAT). You should document that
> or move it to a separate patch.

I add two features.  And I so in the commit log, though I didn't
actually say what those do.  I can fix that up.

> 
> > +/* Features of various MAL implementations */
> > +
> > +/* Dummy feature bit so the enum works properly */
> > +#define MAL_FTR_DUMMY	0x00000001
> 
> Nah. Just stick an | 0 in the enum to make it happy.

OK.  I did that originally, but for some reason I wanted to avoid
having FTRS_ALWAYS and FTRS_POSSIBLE be equal if none of the Kconfig
options were set.  I can't remember why though.

josh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html