[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 09 Sep 2008 12:34:49 +0300
From: "Eilon Greenstein" <eilong@...adcom.com>
To: "David Miller" <davem@...emloft.net>
cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"Yitchak Gertner" <yitchak.gertner@...adcom.com>
Subject: Re: [PATCH] bnx2x: EEH recovery fix
On Mon, 2008-09-08 at 12:47 -0700, David Miller wrote:
> From: "Eilon Greenstein" <eilong@...adcom.com>
> Date: Mon, 8 Sep 2008 03:22:32 -0700
>
> > The EEH mechanism caused a fatal error when using the bnx2x since
> > the driver attempted accessing the device after it was reset by the
> > EEH. This patch sets a proper unload when EEH error is detected
> > without accessing the device.
> >
> > Since the current implementation causes a fatal error, I ask that
> > you will consider applying this patch.
>
> What user has run into and reported this failure, and is it
> a regression compared to 2.6.26?
IBM found it on PPC and it was more obvious with the DMA mapping
violation. It is broken in the same way on 2.6.26 as well.
>
> That is the criteria for my putting this patch in now.
>
> Since EEH triggers are an exceedingly corner case error condition,
> this puts this patch even less valid to go in outside of the merge
> window.
>
If you cannot accept it into 2.6.27, I will re-send it into net-next.
Please let me know.
Thanks,
Eilon
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists