lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Sep 2008 12:44:05 +0200 From: Denis Joseph Barrow <D.Barow@...ion.com> To: Paulius Zaleckas <paulius.zaleckas@...tonika.lt> CC: linux-usb@...r.kernel.org, netdev <netdev@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...e.de> Subject: Re: hso: remove usb_driver_claim_interface() Hi Paulius, I'm not in a position yet to know if this patch is good, yet at least. hso_probe gets called once for each serial ttyHSx device usually four per usb stick modem & once for the hsox network device per modem. >From the comment on usb_driver_claim_interface * This is used by usb device drivers that need to claim more than one * interface on a device when probing (audio and acm are current examples). I'm not used to USB terminology >From my understanding of the code we are claiming more than one interface on the usb modem multiple ttyHSx devices & one network device. However we get probed once for each interface We are also calling usb_driver_release_interface from hso_disconnect. This looks a little asymmetrical to me. Greg is this patch good? I've no problem with it if it gets your guys blessing. Index: linux-2.6/drivers/net/usb/hso.c =================================================================== --- linux-2.6.orig/drivers/net/usb/hso.c +++ linux-2.6/drivers/net/usb/hso.c @@ -2487,8 +2487,6 @@ static int hso_probe(struct usb_interfac goto exit; } - usb_driver_claim_interface(&hso_driver, interface, hso_dev); - /* save our data pointer in this device */ usb_set_intfdata(interface, hso_dev); Paulius Zaleckas wrote: -- best regards, D.J. Barrow -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists