netdev - Re: [PATCH] r8169: read MAC address from EEPROM on init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Sep 2008 11:38:12 +0200
From:	Ivan Vecera <ivecera@...hat.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>,
	Netdev <netdev@...r.kernel.org>,
	Edward Hsu <edward_hsu@...ltek.com.tw>
Subject: Re: [PATCH] r8169: read MAC address from EEPROM on init

Francois Romieu wrote:
> Ivan Vecera <ivecera@...hat.com> :
> [...]
>> OK :-), I hope the patch below is finally the right one.
> 
> My approval ratings won't surge today.
> 
> Is there a specific explanation for the 10 us delay ?
> 
> Realtek's 8168 / 8169 / 8101 drivers all use a (wildly copy'pasted ?)
> 10 ms delay. I would not mind a 10 ms sleep.
'pci_vpd_pci22_wait' uses 100us(10x10us delay) for reading, there is 1ms
(100x10us delay) in my patch, because 100us max. delay was too little for
Realtek. I tried the patch (with 1ms) on 8169,8168b and 8102e HW without
any problem. IMHO Realtek's 10ms delay (usually used for VPD write access)
is too much...

Ivan

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html