netdev - Re: [patch for 2.6.27? 10/10] gianfar: free/iounmap memory after an error in mii bus initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 24 Sep 2008 20:49:59 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	netdev@...r.kernel.org, afleming@...escale.com, danielm77@...ay.se
Subject: Re: [patch for 2.6.27? 10/10] gianfar: free/iounmap memory after
 an error in mii bus initialization

akpm@...ux-foundation.org wrote:
> From: Andy Fleming <afleming@...escale.com>
> 
> Recent changes to MII bus initialization code added exit points which
> didn't free or iounmap the bus before returning.
> 
> Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11372.
> 
> Signed-off-by: Andy Fleming <afleming@...escale.com>
> Reported-by: Daniel Marjamki <danielm77@...ay.se>
> Cc: Jeff Garzik <jeff@...zik.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/gianfar_mii.c |   14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff -puN drivers/net/gianfar_mii.c~gianfar-free-iounmap-memory-after-an-error-in-mii-bus-initialization drivers/net/gianfar_mii.c
> --- a/drivers/net/gianfar_mii.c~gianfar-free-iounmap-memory-after-an-error-in-mii-bus-initialization
> +++ a/drivers/net/gianfar_mii.c
> @@ -211,19 +211,21 @@ static int gfar_mdio_probe(struct device
>  	gfar_write(&enet_regs->tbipa, 0);
>  	for (i = PHY_MAX_ADDR; i > 0; i--) {
>  		u32 phy_id;
> -		int r;
>  
> -		r = get_phy_id(new_bus, i, &phy_id);
> -		if (r)
> -			return r;
> +		err = get_phy_id(new_bus, i, &phy_id);
> +		if (err)
> +			goto bus_register_fail;
>  
>  		if (phy_id == 0xffffffff)
>  			break;
>  	}
>  
>  	/* The bus is full.  We don't support using 31 PHYs, sorry */
> -	if (i == 0)
> -		return -EBUSY;
> +	if (i == 0) {
> +		err = -EBUSY;
> +
> +		goto bus_register_fail;
> +	}
>  
>  	gfar_write(&enet_regs->tbipa, i);

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html