lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Sep 2008 21:34:30 +0200 From: Jesper Dangaard Brouer <jdb@...x.dk> To: Patrick McHardy <kaber@...sh.net> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: Bisect'ed BUG in VLAN promisc mode (6c78dcbd47) On Fri, 2008-09-26 at 21:28 +0200, Patrick McHardy wrote: > Patrick McHardy wrote: > > Jesper Dangaard Brouer wrote: > >> On Fri, 2008-09-26 at 18:14 +0200, Patrick McHardy wrote: > >>> Jesper Dangaard Brouer wrote: > >>>> Hi Patrick, > >>>> > >>>> Bisected me down to one of you changes > >>>> commit 6c78dcbd47a68a > >>>> [VLAN]: Fix promiscous/allmulti synchronization races > >>>> > >>>> Description: > >>>> ------------ > >>>> All other VLAN interfaces stop working, if a vlan is taken down > >>>> (ifconfig eth1.1025 down) _while_ there is a tcpdump running on that > >>>> interface. > >>>> > >>>> The problem is a result of promisc mode being removed on the > >>>> real-device (eth1), when the vlan interface is taken down. This > >>>> should not happen as other vlan devices exists that still need > >>>> promisc mode on the real-device (eth1). > >>> I'm pretty sure we fixed this already in commit 0ed21b32. > >> > >> I think that I have tested including this commit. The first thing I did > >> was to test with latest DaveM net-2.6 git tree. > > > > Let me see if I can reproduce it ... > > Actually - one question: you're saying you're using different MAC > addresses on the VLAN devices, so I guess thats why you're expecting > the underlying device to still be in promiscous mode after you set > eth1.1025 down. For devices that support multiple unicast addresses > in hardware, we don't put the device in promiscous mode anymore. > So the question is: is something actually not working, or did you > just notice that the real device is no longer in promiscous mode? It stopped working! In the test setup I do have a machine connected to eth1.1013, where I have a ping running, that stop working... I use the tg3 driver for both netcards. Don't know if it supports it? -- Med venlig hilsen / Best regards Jesper Brouer ComX Networks A/S Linux Network developer Cand. Scient Datalog / MSc. Author of http://adsl-optimizer.dk LinkedIn: http://www.linkedin.com/in/brouer -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists