netdev - RE: [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2008 15:01:09 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"David Miller" <davem@...emloft.net>, <bhutchings@...arflare.com>
Cc:	<kaber@...sh.net>, <netdev@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>,
	<e1000-devel@...ts.sourceforge.net>
Subject: RE: [PATCH RFC]: e1000: allow VLAN devices to use TSO and CSUM offload

David Miller wrote:
>> vlan_features is a mask for features.  So long as all parts that do
>> support TSO-IPv6 also support it for VLAN-tagged packets, it should
>> be safe to set NETIF_F_TSO6 in vlan_features unconditionally.
> 
> Right, it's an additional mask which gets and'd with the normal
> device feature bits.
> 
> Jesse, any objections, given that?

No, once that is explained I think it gets rid of any objections.  We
are going to test the patch now, so would you mind if you waited to take
it until jkirsher pushes it to you?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html