netdev - Re: [PATCH 2/4] tcpv6: trivial formatting changes to send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2008 15:00:39 +0300 (EEST)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	David Miller <davem@...emloft.net>
cc:	Arnaldo Carvalho de Melo <acme@...hat.com>,
	yoshfuji@...ux-ipv6.org, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/4] tcpv6: trivial formatting changes to send_(ack|reset)

On Thu, 9 Oct 2008, David Miller wrote:

> From: David Miller <davem@...emloft.net>
> Date: Thu, 09 Oct 2008 14:38:59 -0700 (PDT)
> 
> > From: Arnaldo Carvalho de Melo <acme@...hat.com>
> > Date: Thu, 9 Oct 2008 11:16:58 -0300
> > 
> > > Em Thu, Oct 09, 2008 at 12:58:07PM +0300, Ilpo Järvinen escreveu:
> > > > On Thu, 9 Oct 2008, YOSHIFUJI Hideaki / ???? wrote:
> > > > > I usually prefer sizeof(var) (or sizeof(*ptr)) over sizeof(type).
> > > > > Could you justify this change?
> > > > 
> > > > My point was to make those two functions as equal as possible before merge 
> > > > so that it's more easier to track what happens at the merge, both 
> > > > versions pre-existed anyway. Sure I don't have much opinion either way.
> > > 
> > > I agree with Yoshifuji, albeit it is unlikely that the type of that
> > > variable will change 8)
> > 
> > I agree as well

Ok. I keep this in mind in future (both versions pre-existed the
choice I made was just arbitary)... :-)

-- 
 i.