lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 11 Oct 2008 23:26:11 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Patrick McHardy <kaber@...sh.net> Cc: "David S. Miller" <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: gre: minor cleanups in netlink interface On Sat, Oct 11, 2008 at 05:15:40PM +0200, Patrick McHardy wrote: > > We usually use two values (value + mask) for flags. Aha that should handle it nicely. >> Also, for ikey/okey we'll need to introduce another attribute to >> indicate their presence as well as their value. > > The flags already indicate whether keys should be used, don't > they? So if you want to unset them, you can simply unset the > GRE_KEY flag. Right if you have the flag then it's not an issue. > I'll give it a shot and will post a patch, probably tommorrow. Thanks! >> Hmm, it seems that there is a bug in how we treat a zero key. >> You can't have a tunnel with a zero key and one with no key at >> the same time. >> >> In fact my latest iproute patch has a similar problem. You >> can't unset the ikey/okey except by deleting the tunnel. On >> the other hand the old ip tunnel interface has the same bug :) > > I can't find it :) If you mean the patch, then you're on the cc list :) If you mean the bug in ip tunnel, I was going by the fact that there is nothing that unsets the GRE_KEY flag. Actually let's not worry about this one too much because you can't unset the checksum flags either and nobody has complained about either of these problems for a decade. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists