netdev - Re: [PATCH] [stable 2.6.27.y] don't take the mdio_lock in atl1e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Oct 2008 11:08:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jacliburn@...lsouth.net
Cc:	stable@...nel.org, willy@...ux.intel.com, jgarzik@...hat.com,
	csnook@...hat.com, jie.yang@...eros.com, netdev@...r.kernel.org,
	jcliburn@...il.com, nm127@...email.hu, akpm@...ux-foundation.org
Subject: Re: [PATCH] [stable 2.6.27.y] don't take the mdio_lock in
 atl1e_probe

From: Jay Cliburn <jacliburn@...lsouth.net>
Date: Sat, 11 Oct 2008 10:05:01 -0500

> From: Matthew Wilcox <matthew@....cx>
> 
> Upstream commit: f382a0a8e9403c6d7f8b2cfa21e41fefb5d0c9bd
> 
> This fixes bug 11736.
> 
> http://marc.info/?l=linux-netdev&m=122367387219316&w=2
> 
> Lockdep warns about the mdio_lock taken with interrupts enabled then
> later taken from interrupt context.  Initially, I considered changing
> these to spin_lock_irq/spin_unlock_irq, but then I looked at
> atl1e_phy_init() and saw that it calls msleep().  Sleeping while
> holding a spinlock is not allowed either.
> 
> In the probe path, we haven't registered the interrupt handler, so
> it can't poke at this card yet.  It's before we call register_netdev(),
> so I don't think any other threads can reach this card either.  If I'm
> right, we don't need a spinlock at all.
> 
> Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>

Signed-off-by: David S. Miller <davem@...emloft.net>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html