netdev - Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit compile failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 12 Oct 2008 23:09:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	grundler@...isc-linux.org
Cc:	linux-driver@...gic.com, netdev@...r.kernel.org,
	ron.mercer@...gic.com, linux-ia64@...r.kernel.org
Subject: Re: [PATCH] 2.6.27-rc9 QGLE make unsupported page size explicit
 compile failure

From: Grant Grundler <grundler@...isc-linux.org>
Date: Mon, 13 Oct 2008 00:06:15 -0600

> QLGE driver only supports 4k, 8k, and 64k pages.
> Default page size on ia64 is 16k. Compile fails with:
> drivers/net/qlge/qlge.h:1118: error: 'TX_DESC_PER_OAL' undeclared here (not in a function)
> 
> Patch below makes the cause of the compile failure obvious.
> (Better would be to support 16k pages but I don't have the HW or interest.)
> 
> Signed-off-by: Grant Grundler <grundler@...isc-linux.org>

I would rather, at this point, give the qlge guys a day or two to
try and add support for other page sizes if that is possible.

If it isn't possible, I'd rather see a Kconfig guard, a compile
failure is really not acceptable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html