lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Oct 2008 21:35:04 +0200 From: Marcin Slusarz <marcin.slusarz@...il.com> To: Manish Katiyar <mkatiyar@...il.com> Cc: kernel-janitors@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] : Fix compilation warnings in net/802/fc.c On Tue, Oct 14, 2008 at 11:51:24PM +0530, Manish Katiyar wrote: > [ I was not sure about which list is this appropriate, so putting > kernel-janitors since this is cleanup] Cc'ing netdev@...r > > Below patch fixes the following warning during compilation. > net/802/fc.c:85: warning: unused variable 'fch' > > Signed-off-by: Manish Katiyar <mkatiyar@...il.com> > > --- > net/802/fc.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/net/802/fc.c b/net/802/fc.c > index cb3475e..7463109 100644 > --- a/net/802/fc.c > +++ b/net/802/fc.c > @@ -82,7 +82,9 @@ static int fc_header(struct sk_buff *skb, struct > net_device *dev, > > static int fc_rebuild_header(struct sk_buff *skb) > { > +#ifdef CONFIG_INET > struct fch_hdr *fch=(struct fch_hdr *)skb->data; > +#endif > struct fcllc *fcllc=(struct fcllc *)(skb->data+sizeof(struct fch_hdr)); > if(fcllc->ethertype != htons(ETH_P_IP)) { > printk("fc_rebuild_header: Don't know how to resolve type %04X > addresses ?\n", ntohs(fcllc->ethertype)); > -- When !CONFIG_INET this function always returns 0 (and does not anything useful) so it probably can be written as: #ifdef CONFIG_INET static int fc_rebuild_header(struct sk_buff *skb) { ... } #else static int fc_rebuild_header(struct sk_buff *skb) { return 0; } #endif Marcin -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists