lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 17 Oct 2008 15:36:03 +0200 From: Ingo Molnar <mingo@...e.hu> To: Patrick McHardy <kaber@...sh.net> Cc: Pablo Neira Ayuso <pablo@...filter.org>, David Miller <davem@...emloft.net>, torvalds@...ux-foundation.org, akpm@...ux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, benh@...nel.crashing.org Subject: Re: [GIT]: Networking * Patrick McHardy <kaber@...sh.net> wrote: > Pablo Neira Ayuso wrote: >> Ingo Molnar wrote: >>> * Patrick McHardy <kaber@...sh.net> wrote: >>> >>>>> net/netfilter/nf_conntrack_netlink.c:819: warning: ‘enum >>>>> nf_nat_manip_type’ declared inside parameter list >>>>> net/netfilter/nf_conntrack_netlink.c:819: warning: its scope is >>>>> only this definition or declaration, which is probably not what >>>>> you want >>>>> net/netfilter/nf_conntrack_netlink.c:818: error: parameter 2 >>>>> (‘manip’) has incomplete type >>>> Thanks Ingo. I just sent this patch to Benjamin Herrenschmidt >>>> for testing. >>> >>> build still fails with the attached config. >> >> This should fix it. I have slightly tested it here with your config. >> > > Applied, thanks Pablo. > > I'll look into cleaning up those conditional includes. Its getting > more and more complicated to even build-test all the combinations. yeah - very often build errors in rare .config scenarios are canaries for structural problems. (We had such a situation in the x86 code recently: we had those quirky x86 subarchitectures, and they were a constant source of build errors that no real user actually cared about - because there were no active users left. We modularized them into the main platform and we havent had a single build bug in them in the last couple of months.) Ingo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists