netdev - Re: [Bugme-new] [Bug 11754] New: tlan network driver does not work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 24 Oct 2008 17:18:35 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Robert Fitzsimons <robfitz@...k.net>
Cc:	Manfred Scherer <manfred.scherer.mhm@...nline.de>,
	Michal Ostrowski <mostrows@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	netdev@...r.kernel.org, bugme-daemon@...zilla.kernel.org,
	Robert Fitzsimons <robfitz@...k.net>
Subject: Re: [Bugme-new] [Bug 11754] New: tlan network driver does not work

On Sat, 25 Oct 2008 01:00:33 +0100
Robert Fitzsimons <robfitz@...k.net> wrote:

> I've double checked my patch and still think it's correct.  Lets quickly
> review it:
> 
> @@ -360,8 +360,8 @@ TLan_GetSKB( const struct tlan_list_tag *tag)
>  {
>  	unsigned long addr;
>  
> -	addr = tag->buffer[8].address;
> -	addr |= (tag->buffer[9].address << 16) << 16;
> +	addr = tag->buffer[9].address;
> +	addr |= (tag->buffer[8].address << 16) << 16;

There is upper_32_bits(x) and lower_32_bits(x) for this (see kernel.h)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html