netdev - Re: Doubts about the get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 3 Nov 2008 14:24:22 -0600
From:	"Andy Fleming" <afleming@...il.com>
To:	"Giuseppe CAVALLARO" <peppe.cavallaro@...com>
Cc:	netdev@...r.kernel.org
Subject: Re: Doubts about the get_phy_id function.

On Wed, Oct 29, 2008 at 3:12 AM, Giuseppe CAVALLARO
<peppe.cavallaro@...com> wrote:
> Hi All,
> Using a bad PHY address, the physical device is erroneously attached to the
> MAC device driver.
> This happens because the get_phy_id function reads zero from the PHYIR1/2
> regs and never fails.
> I'm facing this problem on some PHY devices (*) but I've not clear enough if
> this can actually depend on an HW issue (e.g.invalid  phy addresses have
> been left floating) or we need to apply the patch below. Indeed, it helps me
> to catch the problem and, as final result, the phy_connect always fails on
> wrong PHY address and the network interface cannot be opened.
>
> (*) on other ones, the get_phy_id function reads 0xffff from PHYIR1/2 regs
> and fails (as expected results) when I try to attach a wrong PHY address.

Some people seem to have PHYs that report 0 as their ID, so that's not
going to work.  I'm pretty sure your bus needs to be floating high, so
you might want to check that out.

Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html