netdev - Re: zeroing dev->irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 03 Nov 2008 19:28:20 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	andy@...yhouse.net, mcarlson@...adcom.com, netdev@...r.kernel.org,
	mchan@...adcom.com
Subject: Re: zeroing dev->irq

From: Jeff Garzik <jeff@...zik.org>
Date: Fri, 31 Oct 2008 12:47:50 -0400

> Andy Gospodarek wrote:
> > This came up because the output is currently wrong.
> > # ifconfig eth0 | grep Inter && grep eth0 /proc/interrupts
> >           Interrupt:169 Memory:f6000000-f6012100
> > 122:       2894           0          0         PCI-MSI  eth0
> > Some drivers take the stand of not setting dev->irq anything (like most
> > of the Intel drivers), but I didn't take that route with tg3 (or with
> > the others I'd planned) simply because I didn't want to hear crying
> > about breaking user-space with a patch that would make that line
> > disappear.
> > If this seems like a reasonable change that we can force on user-space
> > I'll post a patch that drops the setting of dev->irq all together, so
> > this disappers.
>
> I would vote for zeroing dev->irq in not only tg3, but also other
> modern, ethtool-enabled drivers...  It is a relic of the ISA days,
> and is incompatible with multiple MSI vector scenarios, something
> also found on some non-x86 and embedded ethernet drivers.
>
> For years now, dev->irq has been providing information on an
> unreliable, best-effort basis.  I prefer definitive, reliable,
> predictable behaviors, and think always-zero is therefore an
> improvement.
>
> Comments welcome...

I completely agree with Jeff and I'll happily take patches
which do this into net-next-2.6
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html