netdev - Re: [PATCH] vlan: Fix typos in proc output string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 00:20:17 +0100
From:	Ferenc Wagner <wferi@...f.hu>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] vlan: Fix typos in proc output string

David Miller <davem@...emloft.net> writes:

> From: Ferenc Wagner <wferi@...f.hu>
> Date: Thu, 06 Nov 2008 12:18:27 +0100
>
>> Signed-off-by: Ferenc Wagner <wferi@...f.hu>
>  ...
>> @@ -314,7 +314,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
>>  		   dev_info->ingress_priority_map[6],
>>  		   dev_info->ingress_priority_map[7]);
>>  
>> -	seq_printf(seq, "EGRESSS priority Mappings: ");
>> +	seq_printf(seq, " EGRESS priority mappings: ");
>>  	for (i = 0; i < 16; i++) {
>>  		const struct vlan_priority_tci_mapping *mp
>>  			= dev_info->egress_priority_map[i];
>
> The typo fix is clearly correct, but adding the leading
> space is not.  Are you simply trying to make the values
> line up with the INGRESS ones on the previous line?

Not as much the values, as those are separated by single spaces on the
egress line but double spaces on the ingress line, except for 6 and 7,
so that is a mess anyway (shall I send another most important patch to
this end?)  But I find the titles easier to parse when their common
parts are lined up.

> Anyways, I'm applying this fix, but I wish you had clarified
> the change as it wasn't totally clear even to me.

Thanks, sorry, and next time I will try to be more explicit.
-- 
Regards,
Feri.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html