netdev - Re: [PATCH] phylib: make mdio-gpio work without OF (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 11:03:52 +0200
From:	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
To:	Laurent Pinchart <laurentp@...-semaphore.com>
CC:	netdev@...r.kernel.org, linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-embedded@...r.kernel.org,
	Grant Likely <grant.likely@...retlab.ca>,
	Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH] phylib: make mdio-gpio work without OF (v3)

Laurent Pinchart wrote:
> Hi Paulius,
> 
> sorry for the late reply. I've been busy at work with a release and had no 
> time to test the patch. Comments follow.
> 
> On Monday 10 November 2008, Paulius Zaleckas wrote:
>> make mdio-gpio work with non OpenFirmware gpio implementation.
>>
>> Aditional changes to mdio-gpio:
>> - use gpio_request() and gpio_free()
>> - place irq[] array in struct mdio_gpio_info
>> - add module description, author and license
>> - add note about compiling this driver as module
>> - rename mdc and mdio function (were ugly names)
>> - change MII to MDIO in bus name
>> - add __init __exit to module (un)loading functions
>> - probe fails if no phys added to the bus
>> - kzalloc bitbang with sizeof(*bitbang)
>>
>> Changes since v2:
>> - more #ifdefs reduction
>> - platform driver will be registered on OF platforms also
>> - unified platform and OF bus_id to phy%i
>>
>> Changes since v1:
>> - removed NO_IRQ
>> - reduced #idefs
>>
>> Laurent, please test this driver under OF.
> 
> Unfortunately this breaks on OF platforms (at least on mine):
> 
> ~ # ifconfig eth0 up
> [  258.886051] eb:01 not found
> [  258.887409] eth0: Could not attach to phy
> 
> The bus id was "%x"...
>
> And you renamed it to phy%i. Ethernet drivers relying on the id should be 
> updated as well.

I done this to be closer to what phylib documentation says...
I did search over drivers and found out that almost all of them uses "%x"...

> Updating drivers/net/fs_enet/fs_enet-main.c (in find_phy) fixed the problem 
> for my platform. Please not that this requires a change to 
> drivers/net/fs_enet/mii-bitbang.c (in fs_mii_bitbang_init) as well.

A lot more than that...
So actually it is better to just change it back to "%x".

Waiting for comments from other people and I will respin patch with this change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html