netdev - Re: [PATCH] bnx2: fix poll_controller method so that proper structures are passed and all rx queues are checked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 09:59:24 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Neil Horman" <nhorman@...driver.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"jgarzik@...ox.com" <jgarzik@...ox.com>,
	"'davem@...emloft.net'" <davem@...emloft.net>
Subject: Re: [PATCH] bnx2: fix poll_controller method so that proper
 structures are passed and all rx queues are checked


On Tue, 2008-11-11 at 09:37 -0800, Neil Horman wrote:
> Copy that.  Here you go, followon patch to change how we pass the irq vector to
> bnx2_interrupt.  Doesn't do anything super-usefull, but good for the sake of
> correctness

Sorry, I missed something earlier.  After looking at this more closely,
we should also move disable_irq() into the loop and call it with the
same vector values from irq_tbl.

Thanks.
> 
> Regards
> Neil
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>
> 
> 
>  bnx2.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index 9e1f0e3..cad8b7a 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -7208,7 +7208,7 @@ poll_bnx2(struct net_device *dev)
>  
>         disable_irq(bp->pdev->irq);
>         for (i = 0; i < bp->irq_nvecs; i++)
> -               bnx2_interrupt(bp->pdev->irq, &bp->bnx2_napi[i]);
> +               bnx2_interrupt(bp->irq_tbl[i].vector, &bp->bnx2_napi[i]);
>         enable_irq(bp->pdev->irq);
>  }
>  #endif


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html